feat(button): removed dark theme from buttons #2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2038 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 84 84
Lines 3718 3718
Branches 485 485
=======================================
Hits 3697 3697
Misses 21 21Continue to review full report at Codecov.
|
kfranqueiro
approved these changes
Jan 23, 2018
packages/mdc-theme/_functions.scss
Outdated
| @@ -42,6 +42,7 @@ $_mdc-theme-tonal-offset: 7%; | |||
|
|
|||
| // Determine whether the color is "light" or "dark". | |||
| @function mdc-theme-tone($color) { | |||
| // TODO: update to remove support for dark | |||
There was a problem hiding this comment.
I'm pretty sure you won't actually want to remove anything here - this is critical to support people who want to set up a dark theme themselves by passing their own colors to variables/mixins. cc @acdvorak to correct me if I'm wrong.
moog16
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.